[Spice-devel] [PATCH v2] sndworker: add AudioVolume/AudioMute messages

[Christophe Fergeau]

Hi,

On Mon, Jun 20, 2011 at 11:40:01PM +0200, Marc-André Lureau wrote:
> These messages allow the guest to send the audio device volume to the
> client. It uses an arbitrary scale of 16bits, which works good enough
> for now.

This adds this arbitrary scale to the protocol, is this scale "good enough"
to be set in stone as is and be supported "forever"?

> @@ -193,7 +205,6 @@ static void snd_disconnect_channel(SndChannel *channel)
>      channel->stream->watch = NULL;
>      reds_stream_free(channel->stream);
>      spice_marshaller_destroy(channel->send_data.marshaller);
> -    free(channel);

I haven't looked carefully at the whole patch, but this change seems out of
place, does it really belong to this patch?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20110620/5fb804f6/attachment.pgp>