[Spice-devel] [PATCH v2] sndworker: add AudioVolume/AudioMute messages

[Marc-André Lureau]

On Tue, Jun 21, 2011 at 2:19 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Tue, Jun 21, 2011 at 12:58:23PM +0200, Marc-André Lureau wrote:
>> So we can simply change the message "volume" in % to "volume_db" in
>> dB, if both parts say they have the capability to handle volume in dB.
>> That's roughly what I had in mind.
>
> Ok, so we'll switch from "arbitrary scale" to "dB" through a capability
> check, good for me, I just wanted to make sure it had been thought
> out/planned. Would it be better to have a "supported audio volume formats"
> capability, and to include the volume format in the message?

Yes, unfortunately, the old spicec client just aborts in case of
unknown messages...

So, I'll do two things:
- add caps for the volume messages
- make spicec just skip unknown messages

What do you mean by "volume format"? It's a an uint16_t, for which 0
means 0% = MUTE, and 65535 or 100% = NORMAL.

-- 
Marc-André Lureau