[Spice-devel] [PATCH] x11: Use _exit rather then exit on X errors (rhbz#680763)

[David Mansfield]

Perhaps the client should fork and the parent process can watch for this
scenario and restore the resolution safely that way?


O
n Tue, 2011-03-01 at 18:25 +0200, Hans de Goede wrote:
> This avoids us trying to restore the original resolution when we're fullscreen
> and an X error happens. As restoring fullscreen is a bad idea then as this
> involves making more X calls, which can get us stuck (in side an XLockDisplay
> call for example).
> ---
>  client/x11/platform.cpp |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/client/x11/platform.cpp b/client/x11/platform.cpp
> index 4877798..48d5a52 100644
> --- a/client/x11/platform.cpp
> +++ b/client/x11/platform.cpp
> @@ -3024,14 +3024,14 @@ static int x_error_handler(Display* display, XErrorEvent* error_event)
>                error_str,
>                (uint32_t)error_event->minor_code,
>                request_str);
> -    exit(-1);
> +    _exit(-1);
>      return 0;
>  }
>  
>  static int x_io_error_handler(Display* display)
>  {
>      LOG_ERROR("x io error on %s", XDisplayString(display));
> -    exit(-1);
> +    _exit(-1);
>      return 0;
>  }
>