[Spice-devel] [PATCH] driver: allowed modes: remove limit of 480 <= {X, Y} <= 2000

[Arnon Gilboa]

NAK, patch seems ok but missing version bump in miniport rc file as well

Alon Levy wrote:
> Later todo is to check that there is available video memory for
> this, but that requires either access to PDev or probably dynamically
> checking anyway to make sure we actually fit. Another option is
> to leave that check in the host (when we do a IO_SETMODE)
>
> Fixes Bugzilla 647865
>
> Bumping version to 1.4.1.1
>
> Tested with winxp 32 bit only.
> ---
>  display/driver.c  |    4 +---
>  display/driver.rc |    4 ++--
>  miniport/qxl.inf  |    2 +-
>  3 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/display/driver.c b/display/driver.c
> index a92eb03..b129f52 100644
> --- a/display/driver.c
> +++ b/display/driver.c
> @@ -298,9 +298,7 @@ DWORD GetAvailableModes(HANDLE driver, PVIDEO_MODE_INFORMATION *mode_info,
>      n = modes.NumModes;
>      while ( n-- ) {
>          if ( (info->NumberOfPlanes != 1 ) ||!(info->AttributeFlags & VIDEO_MODE_GRAPHICS)
> -             ||((info->BitsPerPlane != 16) && (info->BitsPerPlane != 32))
> -             || (info->VisScreenWidth > 2000) || (info->VisScreenWidth < 480)
> -             || (info->VisScreenHeight > 2000) || (info->VisScreenHeight < 480) ) {
> +             ||((info->BitsPerPlane != 16) && (info->BitsPerPlane != 32))) {
>  
>              DEBUG_PRINT((NULL, 1, "%s: unsuported mode rejecting miniport mode\n",  __FUNCTION__));
>              DEBUG_PRINT((NULL, 1, "                   width = %li height = %li\n",
> diff --git a/display/driver.rc b/display/driver.rc
> index 772c6db..4330815 100644
> --- a/display/driver.rc
> +++ b/display/driver.rc
> @@ -16,12 +16,12 @@
>  #define VER_FILEDESCRIPTION_STR     "Red Hat QXL Display Driver"
>  #define VER_INTERNALNAME_STR        "qxldd.dll"
>  #define VER_ORIGINALFILENAME_STR    VER_INTERNALNAME_STR
> -#define VER_FILEVERSION_STR         "1.4.1.0"
> +#define VER_FILEVERSION_STR         "1.4.1.1"
>  #define VER_PRODUCTNAME_STR         "Spice"
>  #define VER_PRODUCTVERSION_STR      VER_FILEVERSION_STR
>  
>  #undef  VER_PRODUCTVERSION
> -#define VER_PRODUCTVERSION           1,4,1,0
> +#define VER_PRODUCTVERSION           1,4,1,1
>  
>  #define VER_COMPANYNAME_STR         "Red Hat Inc."
>  #define VER_LEGALCOPYRIGHT_STR      "� Red Hat Inc. All rights reserved."
> diff --git a/miniport/qxl.inf b/miniport/qxl.inf
> index 3739ac7..0c682b2 100644
> --- a/miniport/qxl.inf
> +++ b/miniport/qxl.inf
> @@ -3,7 +3,7 @@
>  
>  [Version]
>  Signature = "$CHICAGO$"
> -DriverVer = 09/29/2010,1.4.1.0 
> +DriverVer = 03/20/2011,1.4.1.1 
>  Provider = %RHAT%
>  CatalogFile = qxl.cat
>  Class = Display
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>