[Spice-devel] [PATCH 6/8] common: add ssl_verify.c common code

[Christophe Fergeau]

On Tue, May 03, 2011 at 04:37:43PM +0200, Marc-André Lureau wrote:
> Code adapter from RedPeer::ssl_verify_callback() and used by
> spice-gtk.
> 
> Since v1:
>  - fixed Makefile.am
>  - added config.h include
>  - autoconf alloca added in patch series
>  - moved int escape inside for loop
>  - added a failed case when missing assignment
>  - replaced strlen () by -1
>  - skip spaces after comma
>  - c++ guards
> 
> I didn't use bool, because openSSL uses int, and it is more future
> proof for error reporting.
> ---
>  common/Makefile.am  |    2 +
>  common/ssl_verify.c |  481 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  common/ssl_verify.h |   60 +++++++
>  3 files changed, 543 insertions(+), 0 deletions(-)
>  create mode 100644 common/ssl_verify.c
>  create mode 100644 common/ssl_verify.h
> 
> diff --git a/common/Makefile.am b/common/Makefile.am
> index dff9574..5c38b75 100644
> --- a/common/Makefile.am
> +++ b/common/Makefile.am
> @@ -69,5 +69,7 @@ EXTRA_DIST =				\
>  	quic_family_tmpl.c		\
>  	quic_rgb_tmpl.c			\
>  	quic_tmpl.c			\
> +	ssl_verify.h			\
> +	ssl_verify.c			\
>  	$(NULL)

Shouldn't it be in _SOURCES instead of EXTRA_DIST?
Apart from this, ACK.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20110503/0dd101bc/attachment.pgp>