[Spice-devel] [RFC v4 31/62] server/red_worker: fix red_pipe_add_drawable_to_tail

Alon Levy alevy at redhat.com
Thu May 5 06:04:25 PDT 2011


On Tue, May 03, 2011 at 01:56:08AM +0200, Marc-André Lureau wrote:
> Why did you choose to do it seperately from 29/62?
> 

No good reason. I'll merge.

> On Tue, Apr 26, 2011 at 12:54 PM, Alon Levy <alevy at redhat.com> wrote:
> > ---
> >  server/red_worker.c |    8 ++++----
> >  1 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/server/red_worker.c b/server/red_worker.c
> > index 2bc0abf..d6762be 100644
> > --- a/server/red_worker.c
> > +++ b/server/red_worker.c
> > @@ -1263,13 +1263,13 @@ static inline void red_pipe_add_drawable(DisplayChannelClient *dcc, Drawable *dr
> >     red_channel_client_pipe_add(&dcc->common.base, &drawable->pipe_item);
> >  }
> >
> > -static inline void red_pipe_add_drawable_to_tail(RedWorker *worker, Drawable *drawable)
> > +static inline void red_pipe_add_drawable_to_tail(RedChannelClient *rcc, Drawable *drawable)
> >  {
> > -    if (!display_connected(worker)) {
> > +    if (!rcc) {
> >         return;
> >     }
> >     drawable->refs++;
> > -    red_channel_client_pipe_add_tail(worker->display_channel->common.base.rcc, &drawable->pipe_item);
> > +    red_channel_client_pipe_add_tail(rcc, &drawable->pipe_item);
> >  }
> >
> >  static inline void red_pipe_add_drawable_after(DisplayChannelClient *dcc, Drawable *drawable,
> > @@ -6446,7 +6446,7 @@ static void red_add_lossless_drawable_dependencies(RedWorker *worker,
> >
> >     if (!sync_rendered) {
> >         // pushing the pipe item back to the pipe
> > -        red_pipe_add_drawable_to_tail(worker, item);
> > +        red_pipe_add_drawable_to_tail(rcc, item);
> >         // the surfaces areas will be sent as DRAW_COPY commands, that
> >         // will be executed before the current drawable
> >         for (i = 0; i < num_deps; i++) {
> > --
> > 1.7.4.4
> >
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
> >
> 
> 
> 
> -- 
> Marc-André Lureau


More information about the Spice-devel mailing list