[Spice-devel] [PATCH] gtk: Remove redundant code

Marc-André Lureau marcandre.lureau at gmail.com
Tue May 10 09:54:49 PDT 2011


Hi,

I agree with Christophe, some of the debug code should remain to make
life easier when needed. In general, #if 0 is to be interpreted or
perceived as some commented code. And since having code in comment
isn't pretty and it has weird indentation, it is preferable to use #if
0, or #ifndef NDEBUG in some situations. But it shouldn't obfuscate
the code (just like a comment should make it easier to
understand/debug it)

However, I agree some clean up is necessary. Especailly for the #if 1.
I now pushed a modified patch series.

regards


-- 
Marc-André Lureau


More information about the Spice-devel mailing list