[Spice-devel] [PATCH] server/smartcard: fix use after free

Alon Levy alevy at redhat.com
Tue May 24 03:19:12 PDT 2011


---
 server/smartcard.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/server/smartcard.c b/server/smartcard.c
index fed88a5..888b23a 100644
--- a/server/smartcard.c
+++ b/server/smartcard.c
@@ -344,10 +344,10 @@ static void smartcard_channel_send_item(RedChannel *channel, PipeItem *item)
 
 static void smartcard_channel_release_pipe_item(RedChannel *channel, PipeItem *item, int item_pushed)
 {
-    free(item);
     if (item->type == PIPE_ITEM_TYPE_MSG) {
         free(((MsgItem*)item)->vheader);
     }
+    free(item);
 }
 
 static void smartcard_channel_disconnect(RedChannel *channel)
-- 
1.7.5.1



More information about the Spice-devel mailing list