[Spice-devel] [PATCH v2 0/6] Dispatcher infrastructure

[Alon Levy]

On Tue, Nov 08, 2011 at 09:33:20AM +0200, Yonit Halperin wrote:
> Hi,
> Ack series, after fixing the small comments.
> 

Thanks, pushed with the fixes you noted. Added a DISPATCHER_DEBUG
default commented out code to try to catch EINTR, but none caught. I
think it's because the poll is always done after a successful select,
but there are still the polls that fail. Maybe they just don't happen
frequently enough.

> Thanks,
> Yonit.
> On 11/07/2011 01:44 PM, Alon Levy wrote:
> >"introdice dispatcher" patch changed from v1, following Paolo's suggestion to
> >use poll.  verified after the first patch and after the whole bit. (using
> >qxl-win-0.1-12). The large refactor of red_dispatcher has been left almost
> >as is minus some renames for consistency (RedDispatcher is red_dispatcher,
> >Dispatcher is dispatcher). The adding of a dispatcher_register_async_callback
> >and subsequent usage are seperate pataches, as well as introducing an enum
> >DISPATCHER_{NONE,ACK,ASYNC} for it.
> >
> >Please review, (and thanks to the reviews so far!)
> >
> >Alon Levy (6):
> >   server/red_dispatcher: remove semicolon from DBG_ASYNC
> >   server: introduce dispatcher
> >   introduce DISPATCHER_{NONE,ACK,ASYNC}
> >   server/dispatcher: add dispatcher_register_async_callback
> >   server/red_worker: reuse dispatcher
> >   server/red_worker: use dispatcher_register_async_callback
> >
> >  server/Makefile.am       |    2 +
> >  server/dispatcher.c      |  217 +++++++++++
> >  server/dispatcher.h      |  105 ++++++
> >  server/main_dispatcher.c |  102 ++----
> >  server/red_dispatcher.c  |  489 ++++++++++++++-----------
> >  server/red_dispatcher.h  |  149 ++++++++
> >  server/red_worker.c      |  902 +++++++++++++++++++++++++++++-----------------
> >  server/red_worker.h      |    5 +-
> >  8 files changed, 1348 insertions(+), 623 deletions(-)
> >  create mode 100644 server/dispatcher.c
> >  create mode 100644 server/dispatcher.h
> >
>