[Spice-devel] [PATCH vdagent-win 1/3] vdservice: fix vdagent connection & termination handling rhbz#750037

[Arnon Gilboa]

Alon Levy wrote:
> On Wed, Nov 16, 2011 at 12:16:35PM +0200, Arnon Gilboa wrote:
>
> ACK
>
> A few comments / questions below.
>
>   
>> -#define VD_AGENT_TIMEOUT        3000
>> +#define VD_AGENT_TIMEOUT        10000
>>     
>
> Is this required? Do we want to make it configurable?
>   
It's way above what encountered with the wanem (~3.5sec).
I can see no reason for it to be configurable.
Upon such vdagent timeouts, vdservice should suicide, which will be 
added in another patch.
>> -    } else if (err != 0 || err != ERROR_PIPE_CONNECTED) {
>> +    } else if (err != 0 && err != ERROR_PIPE_CONNECTED) {
>>     
>
> This was a bit confusing to track, since ConnectNamedPipe returns non
> zero on success, and I initially missed the ? : in err setting above.
>   
The previous line always evaluates as true, and was rarely reached.