[Spice-devel] [PATCH spice-gtk 3/3] usb-device-manager: Don't g_warning on autoconnect failure

[Marc-André Lureau]

On Sat, Nov 19, 2011 at 4:29 PM, Hans de Goede <hdegoede at redhat.com> wrote:
> We already emit a signal for this, either the app using spice-client-glib
> listens to this signals and does something with it, or it is not interested
> in this happening, at which point logging a g_warning for it is not really
> useful.
>

I would then replace it with a SPICE_DEBUG, it could be helpful for debugging.

> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> ---
>  gtk/usb-device-manager.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
> index 24f9ad1..ec973c6 100644
> --- a/gtk/usb-device-manager.c
> +++ b/gtk/usb-device-manager.c
> @@ -438,7 +438,6 @@ static void spice_usb_device_manager_auto_connect_cb(GObject      *gobject,
>         g_prefix_error(&err, "Could not auto-redirect %s: ", desc);
>         g_free(desc);
>
> -        g_warning("%s", err->message);
>         g_signal_emit(self, signals[AUTO_CONNECT_FAILED], 0, device, err);
>     }
>     if (err)
> --
> 1.7.7.3
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>



-- 
Marc-André Lureau