[Spice-devel] [PATCH spice-gtk 8/8] Release our keyboard grab when we're going to invoke the usb acl helper

[Hans de Goede]

Hi,

Thanks for all the reviews!

On 11/20/2011 11:35 PM, Marc-André Lureau wrote:
> hi
>
> On Wed, Nov 16, 2011 at 6:49 PM, Hans de Goede<hdegoede at redhat.com>  wrote:
>> +    g_object_set(spice_channel_get_session(SPICE_CHANNEL(channel)),
>> +                 "inhibit-keyboard-grab", (gboolean)FALSE, NULL);
>
> I don't think the cast is necessary.

I wasn't sure about it myself either, but note that g_object_set is
a va function, so sizeof arguments matters, and I think that  FALSE will
likely evaluate to an int, so if sizeof(int) != sizeof(gboolean) this
may be an issue, hence the cast. Basically I'm going for better safe then
sorry here.

Regards,

Hans