[Spice-devel] [PATCH spice-gtk 8/8] Release our keyboard grab when we're going to invoke the usb acl helper

Hans de Goede hdegoede at redhat.com
Mon Nov 21 06:31:55 PST 2011


Hi,

On 11/21/2011 02:58 PM, Marc-André Lureau wrote:
> Hi
>
>> I wasn't sure about it myself either, but note that g_object_set is
>> a va function, so sizeof arguments matters, and I think that  FALSE
>> will
>> likely evaluate to an int, so if sizeof(int) != sizeof(gboolean) this
>> may be an issue, hence the cast. Basically I'm going for better safe
>> then
>> sorry here.
>
> The GObject testing code itself is not doing this.
>
> http://git.gnome.org/browse/glib/tree/gobject/tests/binding.c#n522

Ok, I've dropped the casts, and will push a version with them dropped
when I get around to pushing.

Regards,

Hans



More information about the Spice-devel mailing list