[Spice-devel] [PATCH spice-gtk 3/8] Fix a few g-ir-scanner warnings

[Hans de Goede]

Ack.

On 11/23/2011 01:23 PM, Marc-André Lureau wrote:
> ---
>   gtk/Makefile.am         |    2 ++
>   gtk/smartcard-manager.c |    2 +-
>   gtk/spice-util.c        |   13 +++++++++++++
>   3 files changed, 16 insertions(+), 1 deletions(-)
>
> diff --git a/gtk/Makefile.am b/gtk/Makefile.am
> index d770ec1..992c1e9 100644
> --- a/gtk/Makefile.am
> +++ b/gtk/Makefile.am
> @@ -551,6 +551,7 @@ glib_introspection_files =			\
>   	spice-channel.c				\
>   	spice-glib-enums.c			\
>   	spice-option.c				\
> +	spice-util.c				\
>   	channel-cursor.c			\
>   	channel-display.c			\
>   	channel-inputs.c			\
> @@ -559,6 +560,7 @@ glib_introspection_files =			\
>   	channel-record.c			\
>   	channel-smartcard.c			\
>   	channel-usbredir.c			\
> +	smartcard-manager.c			\
>   	usb-device-manager.c            	\
>   	$(NULL)
>
> diff --git a/gtk/smartcard-manager.c b/gtk/smartcard-manager.c
> index df29088..d814ac3 100644
> --- a/gtk/smartcard-manager.c
> +++ b/gtk/smartcard-manager.c
> @@ -246,7 +246,7 @@ static SpiceSmartcardManager *spice_smartcard_manager_new(void)
>    * to it. A new SpiceSmartcardManager instance will be created the first
>    * time this function is called
>    *
> - * Returns: a pointer to the #SpiceSmartcardManager singleton
> + * Returns: (transfer none): a weak reference to the #SpiceSmartcardManager
>    */
>   SpiceSmartcardManager *spice_smartcard_manager_get(void)
>   {
> diff --git a/gtk/spice-util.c b/gtk/spice-util.c
> index b634bf3..f2f30e8 100644
> --- a/gtk/spice-util.c
> +++ b/gtk/spice-util.c
> @@ -148,6 +148,19 @@ closure_invalidated_cb (gpointer ctx_,
>   }
>
>   /* Copied from tp_g_signal_connect_object. See documentation. */
> +/**
> +  * spice_g_signal_connect_object: (skip)
> +  * @instance: the instance to connect to.
> +  * @detailed_signal: a string of the form "signal-name::detail".
> +  * @c_handler: the #GCallback to connect.
> +  * @gobject: the object to pass as data to @c_handler.
> +  * @connect_flags: a combination of #GConnectFlags.
> +  *
> +  * Similar to g_signal_connect_object() but will delete connection
> +  * when any of the objects is destroyed.
> +  *
> +  * Returns: the handler id.
> +  */
>   gulong spice_g_signal_connect_object (gpointer instance,
>                                         const gchar *detailed_signal,
>                                         GCallback c_handler,