[Spice-devel] [PATCH spice-gtk 4/8] Notify when property changed

[Hans de Goede]

Hi,

On 11/23/2011 03:17 PM, Marc-André Lureau wrote:
> Hi
>
> On Wed, Nov 23, 2011 at 3:13 PM, Hans de Goede<hdegoede at redhat.com>  wrote:
>> Hmm, I don't think this is necessary:
>> 1) AFAIK gobject will do the notify itself after calling the property
>> setting,
>
> No it doesn't, you have to do it yourself
>

Are you sure? Because if that is the case then my inhibit keyboard grab
code would not work, and I'm pretty sure it does work. Let me try to make
myself clear, if a property gets changed by the object itself (iow
internally to the object), then yes you should do the notify from the
code making the change. But in this case the gobject class' set_property
is being called from gobject code, iow someone has called g_object_set,
and in that case notifycation does get handled by the gobject code
(or so I believe).

Regards,

Hans