[Spice-devel] [PATCH spice-gtk 2/2] gtk/Makefile.am: Better explicit deps fro autogenerated files

Hans de Goede hdegoede at redhat.com
Sat Sep 3 01:02:20 PDT 2011


Hi,

On 09/02/2011 05:52 PM, Marc-André Lureau wrote:
> Hi
>
> Can't we use BUILT_SOURCES:
> http://sources.redhat.com/automake/automake.html#Sources
>
> BUILT_SOURCES = spice-glib-enums.h spice-widget-enums.h spice-marshal.h

Oh, good one. According to the docs this does have the disadvantage it
will only work for make all and make install, so not for make dist,
but since we include pre-built gtk-doc docs in our tarbal make dist already
does not work without first doing a make all.

So the question is do we wish to fix "make dist" not working without
first doing a make all. I vote for fixing that (which will require
adding some rules to the toplevel makefile), and in that case it
is best to stick with my solution.

Also sometimes it is convenient to be able to do something like:
make -C gtk libspice-client-glib-2.0.la

Which is what the rules in the toplevel Makefile would use to fix
make dist.

Regards,

Hans


More information about the Spice-devel mailing list