[Spice-devel] [PATCH] server: don't call reds_stream_free from worker thread context
Gerd Hoffmann
kraxel at redhat.com
Mon Sep 5 02:02:43 PDT 2011
Hi,
> Hi,
> RED_WORKER_MESSAGE_DISPLAY_DISCONNECT is not the only place that
> triggers red_disconnect_channel (and as a result,
> reds_stream_free(dispatcher->stream)). red_disconnect_channel is called
> also when there is an error upon receive/send and also when timeouts
> related to the client occur (e.g., in flush_display_commands).
Ok.
> We probably better make the dispatcher bi-directional, i.e., not only
> push messages to the worker, but also listen.
That sounds like a non-trivial thing.
What does the master branch here btw? I had a brief look and saw that
the code looks quite different here (probably due to the multiclient work).
cheers,
Gerd
More information about the Spice-devel
mailing list