[Spice-devel] [PATCH] client: don't crash when booting a Xinerama setup

[Christophe Fergeau]

Hey,

On Fri, Sep 16, 2011 at 09:58:58AM +0200, Christophe Fergeau wrote:
> In a Xinerama setup, when X starts up and creates one of the
> secondary screens, first a non-primary surface is created on the
> secondary screen, and then the primary surface for this screen is
> created.
> This causes a crash when the guest uses Xinerama and the client
> is attached to the VM before X starts (ie while the guest is
> booting).
> This happens because DisplayChannel::create_canvas (which is called
> when creating a non-primary surface) assumes a screen has already been
> set for the DisplayChannel while this only happens upon primary surface
> creation. However, it uses the screen for non important stuff, so we
> can test if screen() is non NULL before using it. This is what is done
> in other parts of this file.
> 
> Fixes rhbz #732423

This patch fixes bug #732423 for me. However, I'm still unsure why we are
not hit by this bug in the single screen case, so there's always the
possibility it's papering over another bug...

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20110916/13f2a6bf/attachment.pgp>