[Spice-devel] [PATCH spice-gtk] spice_codegen: Always write a channels entry for an ifdef-ed channel

[Christophe Fergeau]

On Fri, Sep 30, 2011 at 11:24:52AM +0200, Hans de Goede wrote:
> Before this patch, if a channel is defined conditionally in spice.proto
> (because it depends on external headers like the smartcard channel),
> spice_codegen would write an entry to the channels array in
> spice_get_*_channel_parser which would only take up a place in the array
> if the ifdef condition is true, thus moving up all other intializers
> one place when it is not true. This was causing issues (crashes) when building
> spice-gtk with the combination of usbredir support enabled and smartcard
> support disabled.

ACK, good catch indeed.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20110930/5df863dd/attachment.pgp>