[Spice-devel] [PATCH spice-xpi] add support for DisableEffects and ColorDepth

[Christophe Fergeau]

Hey,

On Mon, Apr 02, 2012 at 10:42:32AM +0300, Yonit Halperin wrote:
> @@ -482,6 +484,28 @@ void nsPluginInstance::SetUsbAutoShare(PRBool aUsbAutoShare)
>      // when fixed in RHEVM
>  }
>  
> +/* attribute string ColorDepth; */
> +char *nsPluginInstance::GetColorDepth() const
> +{
> +    return stringCopy(m_color_depth);
> +}
> +
> +void nsPluginInstance::SetColorDepth(const char *aColorDepth)
> +{
> +    m_color_depth = aColorDepth;
> +}
> +
> +/* attribute string DisableEffects; */
> +char *nsPluginInstance::GetDisableEffects() const
> +{
> +    return stringCopy(m_disable_effects);
> +}
> +
> +void nsPluginInstance::SetDisableEffects(const char *aDisableEffects)
> +{
> +    m_disable_effects = aDisableEffects;
> +}
> +

Why isn't color depth an unsigned int?
Disable effects is a comma separated list of effects to disable, right?
(my initial reaction was "why isn't it a boolean?").
Can you list the valid values for disable effects in the commit log at
least?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120402/7b6ce423/attachment.pgp>