[Spice-devel] [spice-gtk 1/2] configure.ac: improve vala detection

[Christophe Fergeau]

On Mon, Apr 02, 2012 at 06:38:23AM -0400, Marc-André Lureau wrote:
> Hi
> 
> ----- Mensaje original -----
> > Currently, configure doesn't check for vala, nor set vala related
> > variables unless --enable-vala was passed. autogen.sh automatically
> > pass --enable-vala if controller.vala.stamp doesn't exist. However,
> > this is not enough since if controller.vala is newer than
> > controller.vala.stamp, we will need to regenerate the vala files,
> > and for that the vala tools are needed.
> > This commit doesn't fully fix this issue, but it at least autodetect
> > vala unless --disable-vala is passed, which will help on systems
> > where
> > vala is installed, but where --enable-vala wasn't explicitly passed.
> 
> In a release tarball, I would prefer it doesn't autodetect vala, but
> rather have people explicitly enable it. In theory, you really don't vala
> in this case, unless you do something special...

You'll need --enable-vala if you want to build the vala bindings, dunno if
that counts as doing "something special". At least libosinfo is
autodetecting vala in this case. This also matches the behaviour for the
generation of the introspection data.

Alternatively, doing unconditionnally --enable-vala in autogen.sh would
work for me too I think.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120402/872c2cfd/attachment.pgp>