[Spice-devel] [PATCH spice-xpi] Validate port values

Marc-André Lureau mlureau at redhat.com
Tue Apr 3 06:39:29 PDT 2012



----- Mensaje original -----
>  
>  void nsPluginInstance::Connect()
>  {
> +    const int port = portToInt(m_port);
> +    const int sport = portToInt(m_secure_port);
> +
> +    if (port < 0)
> +        LOG_ERROR("invalid port: " << m_port);
> +    if (sport < 0)
> +        LOG_ERROR("invalid secure port: " << m_secure_port);
> +    if (port < 0 && sport < 0)
> +        return;

Do we really want to proceed if any of the value is incorrect? I would say no.


More information about the Spice-devel mailing list