[Spice-devel] [spice-xpi 1/4] Move secure channel fixup to secure channel setter

[Uri Lublin]

On 04/03/2012 07:12 PM, David Jaša wrote:
> Hi Christophe,
>
> Christophe Fergeau píše v Út 03. 04. 2012 v 16:38 +0200:
>> The secure channel names need to be fixed for compatibility with
>> older spice versions. However, it's better to do it directly when
>> m_secure_channels is set rather than waiting until its first use
>> ---
>>   SpiceXPI/src/plugin/plugin.cpp |   29 ++++++++++++++---------------
>>   1 file changed, 14 insertions(+), 15 deletions(-)
>>
>> diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp
>> index e3e6e80..04d272b 100644
>> --- a/SpiceXPI/src/plugin/plugin.cpp
>> +++ b/SpiceXPI/src/plugin/plugin.cpp
>> @@ -329,6 +329,20 @@ char *nsPluginInstance::GetSSLChannels() const
>>   void nsPluginInstance::SetSSLChannels(const char *aSSLChannels)
>>   {
>>       m_ssl_channels = aSSLChannels;
>> +
>> +    /*
>> +     * HACK -- remove leading s from m_SSLChannels, e.g. "main" not "smain"
>> +     * RHEL5 uses 'smain' and 'sinpusts
>> +     * RHEL6 uses 'main'  and 'inputs'
>> +     */
> The s- idio^W^W^W^Wlegacy goes much further, see the ovirt-engine
> sources what you can expect:
> http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=backend/manager/tools/engine-config/src/main/resources/engine-config.properties#l109
>
> David

Hi David,
Yes, we need to support all legacy channel names.
Are you able to test it ? Does the attached patch fix that for you?

Thanks,
     Uri

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-SetSSLChannels-remove-leading-s-off-all-spice-channe.patch
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120408/c405c297/attachment.ksh>