[Spice-devel] [PATCH spice-common 4/6] Update spice-protocol submodule

[Hans de Goede]

Hi,

On 04/08/2012 08:44 PM, Alon Levy wrote:
> On Sun, Apr 08, 2012 at 06:42:36PM +0300, Yonit Halperin wrote:
>> For STREAM_DATA_SIZED and QOS_QUERY messages.
>>
>> Signed-off-by: Yonit Halperin<yhalperi at redhat.com>
>> ---
>>   common/rect.h  |    2 +-
>>   spice-protocol |    2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/common/rect.h b/common/rect.h
>> index 0e4b01e..a9c1b08 100644
>> --- a/common/rect.h
>> +++ b/common/rect.h
>> @@ -131,7 +131,7 @@ static inline int rect_contains(const SpiceRect&  big, const SpiceRect&  small)
>>
>>   static inline int rect_get_area(const SpiceRect&  r)
>>   {
>> -    return rect_contains(&r);
>> +    return rect_get_area(&r);
>
> This isn't mentioned in the commit message.

And it looks like it turns this function into a function recursing into itself, unless
we're relying on c++ function overloading here, but common is supposed to be C-only.

Likewise the function prototype looks like it is using c++ conventions, but again common
is supposed to be C only.

Regards,

Hans