[Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

[Christophe Fergeau]

Hey,

On Wed, Feb 22, 2012 at 01:15:30PM +0100, Alon Levy wrote:
> On Wed, Feb 22, 2012 at 11:59:18AM +0100, Marc-André Lureau wrote:
> > On Wed, Feb 22, 2012 at 9:15 AM, Alon Levy <alevy at redhat.com> wrote:
> > > Or do you think it
> > > should diverge simply because different packages will have different
> > > needs at the same time?
> > 
> > I wouldn't say "diverge". It's the same protocol after all, just used
> > at build time only.
> > If we break it, we are screwed anyway.
> 
> It's even not the whole protocol, since the actual on network format is
> not defined there anyway, but in spice-server / spice-gtk. Btw, will you
> be doing a submodule for those parts too? not related, just remembered.

For what it's worth, one scenario where it's easier to go wrong than before
is when distro patches have to be added to the protocol headers (for
example enum values which are used in messages sent over the wire). This
happens when distros decide to backport useful features. Before,
all that was needed was patching one place (spice-protocol), now the header
needs to be patches N times, and it's not even a straight cherry-pick from
git, so I can imagine things going wrong there.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120410/c7106393/attachment.pgp>