[Spice-devel] [PATCH xf86-video-qxl 07/13] (questionable) qxl_surface: qxl_surface_prepare_access: handle unused but set warning with (void)

[Christophe Fergeau]

On Mon, Apr 09, 2012 at 08:33:13PM +0300, Alon Levy wrote:
> ---
>  src/qxl_surface.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/qxl_surface.c b/src/qxl_surface.c
> index 6761bf6..a283d5e 100644
> --- a/src/qxl_surface.c
> +++ b/src/qxl_surface.c
> @@ -863,6 +863,8 @@ qxl_surface_prepare_access (qxl_surface_t  *surface,
>  
>      stride = pixman_image_get_stride (surface->dev_image);
>      height = pixman_image_get_height (surface->dev_image);
> +    (void)height; // XXX keep around for debug?
> +    (void)stride;

They used to be used in #if 0 blocks which were removed in 773fbda754de2dd,
these should be removed too in my opinion.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120410/0543f711/attachment.pgp>