[Spice-devel] [PATCH spice 04/11] client: handle the new SpiceMsgDisplayStreamData (common/messages.h)

[Christophe Fergeau]

On Tue, Apr 10, 2012 at 01:37:25PM +0300, Yonit Halperin wrote:
> 
> On 04/10/2012 01:31 PM, Christophe Fergeau wrote:
> >On Sun, Apr 08, 2012 at 06:43:13PM +0300, Yonit Halperin wrote:
> >>SpiceMsgDisplayStreamData now contains SpiceStreamDataHeader,
> >>which is shared with SpiceMsgDisplayStreamDataSized.
> >>
> >>Signed-off-by: Yonit Halperin<yhalperi at redhat.com>
> >>---
> >>  client/display_channel.cpp |    6 ++++--
> >>  1 files changed, 4 insertions(+), 2 deletions(-)
> >
> >I don't see a spice-protocol/spice-common update there, this means
> >compilation will be broken before or after this change.
> >
> The spice-common commit was part of patch 3 (d36f538). So the client
> build breaks after patch 3. I didn't want to put the sever & client
> patches in the same commit.

I think it would be better to have a commit with only the spice-common
update + the changes to make sure everything compiles, and then do the
functional changes introduced by patch 3.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120410/c0c81322/attachment.pgp>