[Spice-devel] [PATCH] fix error-path return in snd_set_record_peer()

Alon Levy alevy at redhat.com
Tue Apr 17 09:42:52 PDT 2012


On Tue, Apr 17, 2012 at 08:05:04PM +0400, Michael Tokarev wrote:
> The error_{1,2} labels in this functions are backwards.

ACK, pushing.

> 
> Signed-off-by: Michael Tokarev <mjt at tls.msk.ru>
> ---
>  server/snd_worker.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/server/snd_worker.c b/server/snd_worker.c
> index 7bdd399..caffe67 100644
> --- a/server/snd_worker.c
> +++ b/server/snd_worker.c
> @@ -1420,10 +1420,10 @@ static void snd_set_record_peer(RedChannel *channel, RedClient *client, RedsStre
>      snd_record_send(worker->connection);
>      return;
>  
> -error_1:
> +error_2:
>      celt051_decoder_destroy(celt_decoder);
>  
> -error_2:
> +error_1:
>      celt051_mode_destroy(celt_mode);
>  }
>  
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list