[Spice-devel] [PATCH spice-gtk] RFC: widget: improve undesired key repeatition

[Hans de Goede]

Hi,

On 04/22/2012 03:16 PM, Marc-André Lureau wrote:
> Hi
>
> On Sun, Apr 22, 2012 at 9:40 AM, Alon Levy<alevy at redhat.com>  wrote:
>> On Fri, Apr 20, 2012 at 01:59:05AM +0200, Marc-André Lureau wrote:
>>> So it seems like we should keep sending repeat key press in fact. And
>>> it's probably better to rely on client-side repeat, since letting the
>>> server handling it may lead to precisely the bug I was trying to fix.
>>> And we should teach the agent to disable the key repeat function,
>>> which is a trival xset -r, or XGetKeyboardControl /
>>> XChangeKeyboardControl equivalent when a client is connected. Any
>>> other opinion?
>>
>> Using the agent to disable key repeat sounds fine, but you want to do
>> that for windows as well.
>
> Windows doesn't need change, since it seems to use "hardware" key repeat.
>
>> Just to be clear, you propose the client generates the repeat, and the
>> agent disable the guest repeat, so if there is jitter in the network the
>> repeated key press events as seen by the guest would have differing time
>> difference.
>
> Not sure what you mean by "differing time difference", but somehow it
> should be under client control whether there is key repeat.
>
> Hans gave a longer reply, but unfortunately, it was only addressed to
> me. Hans can you resend?

Oops that was not my intention. I've resend it now including the list.

Regards,

Hans