[Spice-devel] [PATCH spice-server] Fix typo in is_equal_brush

Hans de Goede hdegoede at redhat.com
Wed Apr 25 04:47:13 PDT 2012


Hi,

Good one! ACK.

Regards,

Hans


On 04/25/2012 12:23 PM, Daniel P. Berrange wrote:
> The 3 part of the conditional in the is_equal_brush method
> compared the b1->u.color field to itself, instead of b2->u.color
>
> Signed-off-by: Daniel P. Berrange<berrange at redhat.com>
> ---
>   server/red_worker.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index fc74924..e271ae5 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -2346,7 +2346,7 @@ static int is_equal_brush(SpiceBrush *b1, SpiceBrush *b2)
>   {
>       return b1->type == b2->type&&
>              b1->type == SPICE_BRUSH_TYPE_SOLID&&
> -           b1->u.color == b1->u.color;
> +           b1->u.color == b2->u.color;
>   }
>
>   // partial imp


More information about the Spice-devel mailing list