[Spice-devel] [PATCH spice-common] Add missing struct field initializers

Daniel P. Berrange berrange at redhat.com
Wed Apr 25 06:24:25 PDT 2012


On Wed, Apr 25, 2012 at 03:13:26PM +0200, Christophe Fergeau wrote:
> On Wed, Apr 25, 2012 at 02:05:14PM +0100, Daniel P. Berrange wrote:
> > On Wed, Apr 25, 2012 at 03:01:53PM +0200, Christophe Fergeau wrote:
> > > On Wed, Apr 25, 2012 at 10:58:05AM +0100, Daniel P. Berrange wrote:
> > > > From: "Daniel P. Berrange" <berrange at redhat.com>
> > > 
> > > Is that causing issues with newer GCCs? Iirc the rest of the structure is
> > > supposed to be initialized to 0 when it's only partially initialized.
> > 
> > This is a result of -Wmissing-field-initializers - see the other patch
> > for a example of why we want to use that warning flag, and thus need to
> > make all initializers explicit
> 
> Yeah, I saw your other reply after the fact, patch is fine with me then

Thanks, I have pushed this one too


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


More information about the Spice-devel mailing list