[Spice-devel] [PATCH spice] Disable -Waggregate-return if building with SLIRP

[Hans de Goede]

ACK.

On 04/25/2012 04:19 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"<berrange at redhat.com>
>
> The API design of SLIRP means that it is not practical to use
> the -Waggregate-return warning flag. Disable this flag in the
> (unlikely) scenario where SLIRP is actually requested at build
> time
> ---
>   m4/spice-compile-warnings.m4 |    5 ++++-
>   1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/m4/spice-compile-warnings.m4 b/m4/spice-compile-warnings.m4
> index 8de2ffd..601ecf8 100644
> --- a/m4/spice-compile-warnings.m4
> +++ b/m4/spice-compile-warnings.m4
> @@ -148,7 +148,10 @@ AC_DEFUN([SPICE_COMPILE_WARNINGS],[
>       AC_SUBST([WARN_CXXFLAGS])
>
>       # These are C-only warnings
> -    gl_WARN_ADD([-Waggregate-return])
> +    if test "x$enable_tunnel" != "xyes"; then
> +        # Slirp causes pain :-(
> +        gl_WARN_ADD([-Waggregate-return])
> +    fi
>       gl_WARN_ADD([-Wstrict-prototypes])
>       gl_WARN_ADD([-Wold-style-definition])
>       gl_WARN_ADD([-Wnested-externs])