[Spice-devel] [spice-gtk] build: remove --export-symbols fallback

Christophe Fergeau cfergeau at redhat.com
Tue Aug 7 08:39:32 PDT 2012


When -Wl,--version-script is not available, spice-gtk falls back to
using --export-symbols. However, use of --export-symbols does not
have an associate autoconf check to make sure it's available, and
the symbol file it refers to (sym-file) does not exist in git, and
does not seem to be generated during build either. On MacOSX, this
causes the build to fail as -Wl,--version-script is not available
there, and the fallback is not working.
Better to just remove it as at worse we'll be exporting too many
symbols, which can always be fixed.
---
 gtk/Makefile.am | 2 --
 1 file changed, 2 deletions(-)

diff --git a/gtk/Makefile.am b/gtk/Makefile.am
index 785736d..5c4b9bc 100644
--- a/gtk/Makefile.am
+++ b/gtk/Makefile.am
@@ -56,8 +56,6 @@ endif
 
 if HAVE_LD_VERSION_SCRIPT
 VERSION_LDFLAGS = -Wl,--version-script=${srcdir}/map-file
-else
-VERSION_LDFLAGS = -export-symbols ${srcdir}/sym-file
 endif
 
 KEYMAP_GEN = $(srcdir)/keymap-gen.pl
-- 
1.7.11.2



More information about the Spice-devel mailing list