[Spice-devel] [PATCH] spice-ppc: adds powerpc64 mem barriers

[Christophe Fergeau]

Hey,

Thanks for looking into this! Just a few random questions below, mostly
because I'm curious ;)

On Tue, Aug 07, 2012 at 03:46:40PM -0300, sombrafam at gmail.com wrote:
> From: Erlon Cruz <erlon.cruz at br.flextronics.com>
> 
> 
> Signed-off-by: Erlon R. Cruz <erlon.cruz at br.flextronics.com>
> Signed-off-by: Fabiano Fidêncio <Fabiano.Fidêncio at fit-tecnologia.org.br>
> Signed-off-by: Rafael F. Santos <Rafael.Santos at fit-tecnologia.org.br>
> 
> ---
>  spice/barrier.h |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/spice/barrier.h b/spice/barrier.h
> index 710da09..77bce2e 100644
> --- a/spice/barrier.h
> +++ b/spice/barrier.h
> @@ -36,9 +36,11 @@
>  
>  #ifdef __i386__
>  #define spice_mb() __asm__ __volatile__ ("lock; addl $0,0(%%esp)": : :"memory")
> -#else
> +#elif defined __x86_64__
>  //mfence
>  #define spice_mb() __asm__ __volatile__ ("lock; addl $0,0(%%rsp)": : :"memory")
> +#elif defined __PPC64__
> +#define spice_mb()   __asm__ __volatile__ ("sync" : : : "memory")

Do we need a full sync here? Would an lwsync be enough?
Without this, what happens? Is compilation broken? Are things buggy?

Thanks,

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120808/f2cc4614/attachment.pgp>