[Spice-devel] [PATCH 4/7] spice-ppc: fix glz magic endianess

[Christophe Fergeau]

On Tue, Aug 07, 2012 at 03:43:11PM -0300, Erlon Cruz wrote:
> From: Erlon Cruz <erlon.cruz at br.flextronics.com>
> 
> Signed-off-by: Erlon R. Cruz <erlon.cruz at br.flextronics.com>
> Signed-off-by: Fabiano Fidêncio <Fabiano.Fidêncio at fit-tecnologia.org.br>
> Signed-off-by: Rafael F. Santos <Rafael.Santos at fit-tecnologia.org.br>
> ---
>  server/glz_encoder.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/server/glz_encoder.c b/server/glz_encoder.c
> index 1ec1f9b..f8415a8 100644
> --- a/server/glz_encoder.c
> +++ b/server/glz_encoder.c
> @@ -261,7 +261,7 @@ int glz_encode(GlzEncoderContext *opaque_encoder,
>      encoder->cur_image.id = dict_image->id;
>      encoder->cur_image.first_win_seg = dict_image->first_seg;
>  
> -    encode_32(encoder, LZ_MAGIC);
> +    encode_32(encoder, htole32(LZ_MAGIC));

LZ_MAGIC really should be a string that we encode using something like
encode_array(encoder, LZ_MAGIC, sizeof(LZ_MAGIC)), but we don't have such
facilities in glz_encoder.c, so why not. Have you tested that a ppc encoded
glz stream can be decoded on an x86 client? (thinking of it, it might be
the only setup you have tested for now).

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120808/75c6fbde/attachment.pgp>