[Spice-devel] Resend spice-protocol - Fix "make gitignore" subdirectory recursion

[Jeremy White]

> I am fine with using an updated version of git.mk, but I fail to see what it really solves.
> 
> git status is clean here after a build of spice-server or spice-gtk.
> 
> (this discussion is very close to the spice-common Makefile.am usage of SUBDIR vs DIST_SUBDIR. It should probably keep using DIST_SUBDIR and git.mk should perhaps learn to recurse there somehow)

Aha!  Your July 16 patch removing spice-protocol from DIST_SUBDIRS
changes things.  Having spice-protocol in DIST_SUBDIRS exposed the bug
in the spice-protocol/git.mk, because it meant we only descended in to
spice-protocol to run 'make gitignore-recurse'.  Now we descend to run a
normal make as well.

So Behad's patch is still an improvement, but is no longer material, so
I can stop caring either way.

Cheers,

Jeremy

p.s.  You can directly see the bug that Behad fixed by doing this:

git clone git://git.freedesktop.org/git/spice/spice-protocol
cd spice-protocol
./autogen.sh
make gitignore-recurse

and noting that no .gitignore files are made.  A regular make
will create them just fine.