[Spice-devel] [PATCH win-qxl] miniport: fix invalid memory access from previous patch

[Christophe Fergeau]

On Thu, Aug 09, 2012 at 01:46:50PM +0300, Alon Levy wrote:
> On Wed, Aug 08, 2012 at 08:13:29PM +0200, Marc-André Lureau wrote:
> >  miniport/qxl.c |   18 ++++++++++--------
> >  1 file changed, 10 insertions(+), 8 deletions(-)
> > 
> > diff --git a/miniport/qxl.c b/miniport/qxl.c
> > index 44c2a40..003669b 100644
> > --- a/miniport/qxl.c
> > +++ b/miniport/qxl.c
> > @@ -600,6 +600,7 @@ VP_STATUS InitModes(QXLExtension *dev)
> >          return ERROR_INVALID_DATA;
> >      }
> >  
> > +    n_modes += 2;
> 
> So this is basically the fix (allocate the two extra modes) and the rest
> is cleanup.. would be nice to split.

Indeed, I haven't reviewed it since the patch was a bit complex in an area
I'm not familiar with. I probably would have felt comfortable reviewing a
one liner memory corruption fix, and a bigger cleanup patch.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120809/67bc72cf/attachment.pgp>