[Spice-devel] Support for new Composite commands

[Hans de Goede]

Hi,

On 08/19/2012 10:50 PM, Søren Sandmann wrote:
> The following patch sets spanning spice, spice-common, spice-protocol
> and spice-gtk implement support for the following new features:
>
>      - a new A8 surface format
>      - a new Composite command
>
> The Composite command is useful for implementing render suport in the
> X11 guest driver. There are some details about the command in the
> spice-protocol patch.
>
> I have a version of the X driver that makes use of this, and I will send
> those patches for review once they are ready:
>
>      http://cgit.freedesktop.org/~sandmann/xf86-video-qxl/log/?h=render
>
> Feel free to play with it, but note that there are a few known bugs that
> among other things cause it to run out of video memory.

I've done a not too thorough review, remarks:
1) Overall looks good
2) You do not seem to set SPICE_DISPLAY_CAP_COMPOSITE in spice-gtk ?
3) In "[PATCH 2/3] Add support for A8 images to the LZ routines" you introduce
an A8 bitmap_fmt and then rename it to 8BIT_A in "[PATCH 3/3] Add support for
a new Composite request", it would seem better to me to just give it the 8BIT_A
name directly.

Regards,

Hans