[Spice-devel] [spice-gtk PATCH 7/7] migration: copy enable-smartcard and enable-audio state to the migrated session

Yonit Halperin yhalperi at redhat.com
Tue Aug 21 22:31:25 PDT 2012


Hi,
On 08/21/2012 02:14 PM, Marc-André Lureau wrote:
> On Wed, Aug 15, 2012 at 9:56 AM, Yonit Halperin<yhalperi at redhat.com>  wrote:
>> +    g_object_set(copy,
>> +                 "enable-smartcard", c->smartcard,
>> +                 "enable-audio", c->audio,
>> +                 NULL);
>
> like the rest of the c->fields above, you don't need to call
> g_object_set() again.
>
(why "again"?)
Ok, so spice_channel_new should be changed to check SpiceSessionPrivate
fields instead of using g_object_get for the corresponding properties.

> ack otherwise
>



More information about the Spice-devel mailing list