[Spice-devel] [PATCH spice-gtk] channel: rely on couroutine instead of channel state

Hans de Goede hdegoede at redhat.com
Sun Dec 2 13:32:57 PST 2012


Hi,

On 12/02/2012 03:16 PM, Marc-André Lureau wrote:
>
>
> On Sun, Dec 2, 2012 at 12:34 PM, Hans de Goede <hdegoede at redhat.com <mailto:hdegoede at redhat.com>> wrote:
>
>     Hmm, this seems like an unrelated change/fix and one which could do with its own
>     commit message. Otherwise ack.
>
>
> It's actually related, I removed a case in the current iterate_read() (I replaced with a pre-condition instead):
>
> +    g_return_if_fail(c->state != SPICE_CHANNEL_STATE_MIGRATING)
>
> -    case SPICE_CHANNEL_STATE_MIGRATING:
> -        return;
>
> Without that change, we might continue reading/handling incoming data during migration.

Ah, I see, ack for the original patch then.

Regards,

Hans




More information about the Spice-devel mailing list