[Spice-devel] [PATCH v2 spice-gtk 0/5] Add simple HTTP CONNECT proxy

Christophe Fergeau cfergeau at redhat.com
Fri Dec 14 09:27:52 PST 2012


ACK series with 1/5 fixed (feel free to resend just this one if you want a
review)

Christophe

On Fri, Dec 14, 2012 at 05:44:37PM +0100, Marc-André Lureau wrote:
> Hi,
> 
> The following series allows to connect to a Spice server via a HTTP
> proxy, using the CONNECT method. It can be tested with a Squid proxy,
> (which allows CONNECT on various ports) by setting the environment
> variable SPICE_PROXY=proxy_host:proxy_port (it doesn't support any
> other parameters atm, such as username/password)
> 
> The implementation is realized using GSocketClient & GProxy. The HTTP
> proxy is not part of GLib yet, but a fairly complete implementation
> exists in the Wocky project (from Telepathy).
> 
> GLib proxy handling is relatively recent, and requires v2.26.
> Using GSocketClient & GProxy allows to leverage existing and future
> proxy from GLib (currently various socks version supported).
> 
> Since v1:
>  - reordered patches
>  - rebased on current git
> 
> Marc-André Lureau (5):
>   spice-channel: plug a small memory leak
>   spice-channel: remove unnecessary g_socket_close()
>   Add wocky HTTP proxy
>   Add SpiceProxy object
>   session: allow to connect via HTTP CONNECT proxy
> 
>  configure.ac           |   3 +
>  gtk/Makefile.am        |   9 ++
>  gtk/spice-channel.c    |   3 +-
>  gtk/spice-proxy.c      | 236 +++++++++++++++++++++++++++
>  gtk/spice-proxy.h      |  59 +++++++
>  gtk/spice-session.c    | 193 +++++++++++++++-------
>  gtk/wocky-http-proxy.c | 429 +++++++++++++++++++++++++++++++++++++++++++++++++
>  gtk/wocky-http-proxy.h |  42 +++++
>  8 files changed, 917 insertions(+), 57 deletions(-)
>  create mode 100644 gtk/spice-proxy.c
>  create mode 100644 gtk/spice-proxy.h
>  create mode 100644 gtk/wocky-http-proxy.c
>  create mode 100644 gtk/wocky-http-proxy.h
> 
> -- 
> 1.8.1.rc1.17.g75ed918
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20121214/767f5501/attachment-0001.pgp>


More information about the Spice-devel mailing list