[Spice-devel] [PATCH spice-gtk 1/2] session: do not unref() NULL connection

Marc-André Lureau marcandre.lureau at gmail.com
Thu Dec 20 08:31:16 PST 2012


 #3  0x00007ffff59cfb3b in g_object_unref (_object=0x0) at gobject.c:2916
 #4  0x00007ffff6ea9c20 in socket_client_connect_ready (source_object=0x87ced0,
     result=0x8a58f0, data=0x7fffe3fffa80) at spice-session.c:1606
 #5  0x00007ffff5ea1278 in g_task_return_now (task=0x8a58f0) at gtask.c:1102
---
 gtk/spice-session.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gtk/spice-session.c b/gtk/spice-session.c
index 06c1629..0d858fb 100644
--- a/gtk/spice-session.c
+++ b/gtk/spice-session.c
@@ -1603,8 +1603,8 @@ static void socket_client_connect_ready(GObject *source_object, GAsyncResult *re
     g_object_ref(open_host->socket);
 
 end:
-    g_object_unref(connection);
-    g_object_unref(client);
+    g_clear_object(&connection);
+    g_clear_object(&client);
 
     coroutine_yieldto(open_host->from, NULL);
 }
-- 
1.8.1.rc1.17.g75ed918



More information about the Spice-devel mailing list