[Spice-devel] [PATCH] Use non-zero data for initial ping

[Yaniv Kaul]

On 02/14/2012 01:54 AM, Dan McGee wrote:
> On Mon, Feb 13, 2012 at 3:11 PM, Yaniv Kaul<ykaul at redhat.com>  wrote:
>> While the best thing would have been to pass the first image already to the
>> client using those 256K (and calculate the bandwidth based on the first data
>> passed to the client and continue to do so, as the protocol continues), the
>> next best thing would probably be pass *some* image to the client - some
>> JPEG compressed logo or something.
>> This is:
>> (1) already quite compressed.
>> (2) useful in some way.
>> (3) probably 'cheaper' than creating some random data.
>>
>> I think QEMU has this feature (off by default) to load a bootsplash image as
>> part of the BIOS. I wonder if it can be somehow re-used.
> This sounds cool, but also seems overkill for at least this initial
> improvement to the ping functionality, which is completely broken
> right now if compression is involved, as far as I can tell. I'd rather
> get this in first, then let someone else improve it if they find the
> need for something better.

Yes, agreed.

>
> As far as (1) and (3) are concerned, would it be an awful idea to just
> compile this data in? Take something like
> http://gulf.br.tripod.com/wallpaper/tux.jpg (around 256KB), convert it
> to a C unsigned char array, and use that as the data packets.

I think it makes sense to look at what QEMU is doing with the bootsplash 
first.
Y.

>
> For (2), making it useful, that seems like a much bigger proposition
> that I was hoping not to get involved with here.
>
> -Dan