[Spice-devel] [PATCH spice-gtk 1/7] usb: Move various helper functions into usbutil.[c, h]

[Hans de Goede]

Hi,

On 02/19/2012 03:05 PM, Marc-André Lureau wrote:
> On Sun, Feb 19, 2012 at 12:50 AM, Hans de Goede<hdegoede at redhat.com>  wrote:
>> +        return "Success";
>
> did we disussed before that those strings should be translatable if
> they are shown to the user?

No, actually making them translatable is the reason why libusb does not
yet have a libusb_strerror function. Since libusb is cross platform (and also
compiled with say visual-c), the answer is not as easy as use gettext ...

So we can do 2 things:
1) Keep as is for now, and wait for the (translating) libusb_strerror
to show up
2) I can do a patch to make these translatable in spice-gtk, note I believe
this should be a separate patch of this one, as this one is just about moving
the functions around.

> the rest of the patch looks fine to me (given that we agree that some
> day, it should go in a usb library)

Yes we agree on that :)

Regards,

Hans