[Spice-devel] [PATCH spice-gtk 4/7] usbredir: make channel lifetime equal to session lifetime

Marc-André Lureau marcandre.lureau at gmail.com
Mon Feb 20 06:07:57 PST 2012


On Mon, Feb 20, 2012 at 11:07 AM, Hans de Goede <hdegoede at redhat.com> wrote:
>> I would prefer if it didn't call g_error() here.
>
>
> I understand but given that:
> 1) This only happens on memory allocation errors
> 2) glib already does a g_error on memory allocation errors
>   in other places
> 3) Doing other error handling is way more complicated
>
> I believe that this is the best solution here.
>

I still think it's insane to try to deal with allocation error in
usbredir, and it should abort() there, and not in spice-gtk, but we
can make an exception if you are convinced it's the right thing to do.


-- 
Marc-André Lureau


More information about the Spice-devel mailing list