[Spice-devel] [PATCH 2/7] red_worker: rename epoll_timeout to event_timeout

[Alon Levy]

On Mon, Feb 20, 2012 at 06:11:26PM -0600, Dan McGee wrote:
> On Mon, Feb 20, 2012 at 6:07 PM, Dan McGee <dpmcgee at gmail.com> wrote:
> > On Fri, Feb 17, 2012 at 2:52 AM, Alon Levy <alevy at redhat.com> wrote:
> >> On Thu, Feb 16, 2012 at 11:30:08PM -0600, Dan McGee wrote:
> >>> With future patches in mind that will allow for some other
> >>> non-Linux-specific event polling sytem to be used, rename this to a more
> >>> generic name. All of the select/poll/epoll/kqueue family of calls are
> >>> related to evented I/O, so 'event_' makes sense in this case.
> >>
> >> ACK, just note that our coding convention uses 100 char lines, not 80 -
> >> yes, not standard, but also not worth changing everything. In this case
> >> I think it's fine.
> >
> > You're more than welcome to change that back when you commit this; my bad.
> 
> Actually, scratch that.
> 
> $ git commit --amend -a
> error (1): length @ server/red_worker.c +7881
> 
> It is a bit of a pain in the butt to tell people to use these git
> pre-commit hooks when so many of the files are in violation of the
> rules.
> 

I was more interested that you'd know it then pointing out a problem.
You are right that having parts of our code not conform to our coding
convention is bad.

> -Dan
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel