[Spice-devel] [PATCH 0/7] Series of patches to add non-Linux server support

[Alon Levy]

On Thu, Feb 16, 2012 at 11:30:06PM -0600, Dan McGee wrote:
> This is a set of patches to enable building the server library on a non-Linux,
> non-pure-GNU toolchain platform. The patches range from build system tweaks to
> code changes.
> 

I don't have any further problems with this patch series, and everyone
else seems to be busy, so ACK and I'll push it for you. Thanks for the
work,

Alon

> Add configure-time check for -Wl,--version-script option
>     This is a GNU-specific linker option, or at least one not universally
>     supported. It is interesting to note that the Solaris linker does have an
>     '-M' option that seems to take the same format file; however, this patch
>     merely worries about use of the original option.
> 
> red_worker: rename epoll_timeout to event_timeout
> Cleanup definitions of disconnect methods
> Use memcpy call in red_channel_create
>     These three patches are primarily to make the next patch as small and
>     graspable as possible.
> 
> red_worker: reimplement event loop using poll()
>     This is the primary patch in this series. More comments are in the patch
>     notes itself.
> 
> Respect IOV_MAX if defined
> Use standard IOV_MAX definition where applicable
>     This is interesting- here we had a case of coding to the implementation and
>     not the specification. I beefed up the stream_writev_cb() stub before
>     realizing there were no fewer than 3 different constants dealing with IO
>     vector length. So in reality, the actual problem is fixed with either
>     patch, but I think it would be best to get them both in.
> 
> 
> Questions/comments/feedback appreciated! This patch series has been both
> :ompile and run-tested at this point on Linux and Solaris.
> 
> 
> Dan McGee (7):
>   Add configure-time check for -Wl,--version-script option
>   red_worker: rename epoll_timeout to event_timeout
>   Cleanup definitions of disconnect methods
>   Use memcpy call in red_channel_create
>   red_worker: reimplement event loop using poll()
>   Respect IOV_MAX if defined
>   Use standard IOV_MAX definition where applicable
> 
>  configure.ac          |   10 ++++
>  server/Makefile.am    |   12 +++--
>  server/main_channel.c |    2 -
>  server/red_channel.c  |   16 ++----
>  server/red_channel.h  |   12 +++-
>  server/red_worker.c   |  143 ++++++++++++++++++++++++++-----------------------
>  server/reds.c         |   28 +++++++++-
>  server/snd_worker.c   |    9 ++-
>  8 files changed, 140 insertions(+), 92 deletions(-)
> 
> -- 
> 1.7.9.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel