[Spice-devel] Should we auto-redirect USB devices when we show the USB device selection menu?

[Hans de Goede]

Hi,

On 02/21/2012 11:35 AM, Alon Levy wrote:
> On Tue, Feb 21, 2012 at 11:09:49AM +0100, Hans de Goede wrote:
>> Hi,
>>
>> I'm working on some better / prettier error reporting for the usb device widget, and I
>> was wondering should we auto-redirect newly plugged in USB devices when auto-redir
>> is enabled and they get plugged on while showing the USB device selection menu?
>>
>> Currently we do not do this since when we show the widget the SpiceDisplay widget does
>> not have the keyboard focus.
>>
>
> Yes? why not really

Because doing auto-redir when the user has ie a preferences panel which happens
to have the usb device selection widget embedded open, may surprise the user
and surprising the user != good.

, just because it's a little annoying to implement
> since now you have to check keyboard focus not only on the spice widget
> but on any widget or just the whole app (if there is such a notion in
> gtk)?

That is another problem there is no such notion in gtk, as a widget you
cannot find out if another widget of the same window / app is focused,
which sort of makes this whole discussion mute anyways. If we want this it
needs to be done at the app level. Which means more chance to get it wrong,
so I think we should not do it.

Anyways as said not something we can fix at the spice-gtk level, so lets
just keep it as is for now.

Regards,

hans