[Spice-devel] [Qemu-devel] [RFC v4 6/9] qxl: remove flipped

[Alon Levy]

On Wed, Feb 22, 2012 at 12:18:50PM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> It's not obvious to me how the non-flipped case (qxl_stride > 0) is
> handled now.  Have you tested this with both windows+linux guests?

It isn't handled. The simplest way is just to if on the stride and do a
single memcpy instead of individual line memcpy. This of course means we
are doing a redundant copy, since using our own DisplayAllocator or just
the existing deallocate + our own allocate of ds->surface->data removes
one copy. Since the main use case is screendump, I don't think it's a
big deal.

How does that sound?

> 
> cheers,
>   Gerd
> 
>