[Spice-devel] [PATCH] Fix compilation when smartcard support is disabled

Alon Levy alevy at redhat.com
Wed Feb 29 05:19:08 PST 2012


On Wed, Feb 29, 2012 at 01:25:48PM +0100, Christophe Fergeau wrote:
> On Wed, Feb 29, 2012 at 01:35:20PM +0200, Alon Levy wrote:
> > On Wed, Feb 29, 2012 at 12:12:38PM +0100, Christophe Fergeau wrote:
> > > The addition of smartcard control to the controller doesn't handle
> > > the case when smartcard support is disabled at compile time. When
> > > this is the case, this causes compile errors.
> > 
> > ACK. I would probably have just ifdefed the implementation of
> > enable_smartcard
> 
> I'm fine with that too, I can change it if you want. I also wanted #ifdef
> out CONTROLLER_ENABLE_SMARTCARD because it's not yet in the
> mingw-spice-protocol package.

I think yours is better.

> 
> Christophe



> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel



More information about the Spice-devel mailing list